Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate BasicExpressionEvaluator Integration Tests from Tao #19529

Merged
merged 3 commits into from
May 16, 2017
Merged

Migrate BasicExpressionEvaluator Integration Tests from Tao #19529

merged 3 commits into from
May 16, 2017

Conversation

ivanbasov
Copy link
Contributor

  1. Tests only. No ask mode approval is required
  2. There is a missed test to stay at Tao tracked with Migration BasicExpressionEvaluator.EvaluateSimpleExpressionsDTEE integraiton test requires the immeidate window in the DTE API #19527
  3. There is a skipped test failing due to Microsoft.VisualBasic.dll is not loaded by code typed in the immediate window #19526
  4. I will create a separate pull request in roslyn-internal to remove migrated tests from it

Tagging @dotnet/roslyn-ide

jasonmalinowski
jasonmalinowski approved these changes May 16, 2017
View reviewed changes
src/VisualStudio/IntegrationTest/TestUtilities/InProcess/LocalsWindow_InProc.cs Outdated

private EnvDTE.Expression GetEntryInternal(string entryName, EnvDTE.Expressions expressions)
{
// Need to collect nested expressions separately because Expressions cannot be converted to IEnumerable<Expresssion>.
Copy link
Member

@jasonmalinowski jasonmalinowski May 16, 2017 •
edited by ivanbasov
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use the Cast extension method to get a strongly typed enumerable here. #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Fixed

In reply to: 116634198 [](ancestors = 116634198)

@ivanbasov
Copy link
Contributor Author

Tests only. No ask mode approval required

@ivanbasov ivanbasov merged commit ea88bf6 into dotnet:master May 16, 2017
@ivanbasov ivanbasov deleted the basic branch May 16, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@jmarolf jmarolf Awaiting requested review from jmarolf

@tannergooding tannergooding Awaiting requested review from tannergooding

@jinujoseph jinujoseph Awaiting requested review from jinujoseph

Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanbasov @jasonmalinowski @dnfclas